[PATCH] D18802: Improve support for i386 and i486 CPUs.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 5 14:27:17 PDT 2016
RKSimon added a subscriber: RKSimon.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:96
@@ -96,1 +95,3 @@
+ else if (Subtarget.has486Insns())
+ setMaxAtomicSizeInBitsSupported(32); // has cmpxchg
}
----------------
Subtarget.has486Insns() and Subtarget.has586Insns() are quiet vague about actual features, would it not be clearer to instead add Subtarget.hasCMPXCHG8() and Subtarget.hasCMPXCHG() that then uses Has586/Has486 internally?
Same for BSWAP (Subtarget.hasBSWAP()) below.
http://reviews.llvm.org/D18802
More information about the llvm-commits
mailing list