[PATCH] D18802: Improve support for i386 and i486 CPUs.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 21:15:51 PDT 2016


On Tue, Apr 5, 2016 at 2:27 PM Simon Pilgrim via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> RKSimon added a subscriber: RKSimon.
>
> ================
> Comment at: lib/Target/X86/X86ISelLowering.cpp:96
> @@ -96,1 +95,3 @@
> +    else if (Subtarget.has486Insns())
> +      setMaxAtomicSizeInBitsSupported(32); // has cmpxchg
>    }
> ----------------
> Subtarget.has486Insns() and Subtarget.has586Insns() are quiet vague about
> actual features, would it not be clearer to instead add
> Subtarget.hasCMPXCHG8() and Subtarget.hasCMPXCHG() that then uses
> Has586/Has486 internally?
>
> Same for BSWAP (Subtarget.hasBSWAP()) below.
>
>
Yes, this.

Subtarget features should be as specific as possible if you can.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160407/31cce0e8/attachment.html>


More information about the llvm-commits mailing list