[PATCH] D18499: [ELF] - Implemented prototype of location counter support.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 2 08:11:07 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:267-270
@@ -165,1 +266,6 @@
 void ScriptParser::run() {
+  // Dummies sections has empty name, but we still should add
+  // and theat them as normal ouput sections.
+  for (unsigned I = 0; I < dummySectionsNum(); ++I)
+    Script->addLocation(LocOutSec, {""});
+
----------------
grimar wrote:
> ruiu wrote:
> > The concept of dummy sections seems a bit confusing. Could you improve it?
> I guess you mean not only for this patch but whole dummies approach, right ?
> We can probably just get rid of them, like we had before ?
Yes, I'm talking about the approach itself. I'm not sure what you mean by "just get rid of them" (can we do that? I think we need some replacements for them,) but the point is that the code here for the dummy sections seem a bit too complex, so it needs to be improved.


http://reviews.llvm.org/D18499





More information about the llvm-commits mailing list