[PATCH] D18499: [ELF] - Implemented prototype of location counter support.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:267-270
@@ -165,1 +266,6 @@
 void ScriptParser::run() {
+  // Dummies sections has empty name, but we still should add
+  // and theat them as normal ouput sections.
+  for (unsigned I = 0; I < dummySectionsNum(); ++I)
+    Script->addLocation(LocOutSec, {""});
+
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > The concept of dummy sections seems a bit confusing. Could you improve it?
> > I guess you mean not only for this patch but whole dummies approach, right ?
> > We can probably just get rid of them, like we had before ?
> Yes, I'm talking about the approach itself. I'm not sure what you mean by "just get rid of them" (can we do that? I think we need some replacements for them,) but the point is that the code here for the dummy sections seem a bit too complex, so it needs to be improved.
Ok. When I say "get rid" I mean that some time ago they were not sections. So we definetely can do that and just the question "how to do this better now ?" left. I`ll try to suggest some patch to change that.


http://reviews.llvm.org/D18499