[PATCH] D18499: [ELF] - Implemented prototype of location counter support.

[George Rimar via llvm-commits]

grimar added a comment.

Ok, thank you for review, I`ll address this all later today/tomorrow I think (except dummies).


================
Comment at: ELF/LinkerScript.cpp:267-270
@@ -165,1 +266,6 @@
 void ScriptParser::run() {
+  // Dummies sections has empty name, but we still should add
+  // and theat them as normal ouput sections.
+  for (unsigned I = 0; I < dummySectionsNum(); ++I)
+    Script->addLocation(LocOutSec, {""});
+
----------------
ruiu wrote:
> The concept of dummy sections seems a bit confusing. Could you improve it?
I guess you mean not only for this patch but whole dummies approach, right ?
We can probably just get rid of them, like we had before ?


http://reviews.llvm.org/D18499