[PATCH] D18087: [mips] Eliminate instances of "potentially uninitialised local variable" warnings, NFC

[David Blaikie via llvm-commits]

On Fri, Mar 11, 2016 at 1:20 PM, Alexander Riccio via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> ariccio added a comment.
>
> In http://reviews.llvm.org/D18087#373341, @dblaikie wrote:
>
> > I'm still not sure cleaning up these warnings is worthwhile. If we aren't
> >  going to get warning clean & keep the warning on/maintained (in which
> case
> >  I'd really advocate for us to use Clang's version and/or implement the
> >  necessary variant in Clang) what's the merit in rephrasing the cases
> that
> >  aren't buggy (this appears to be such a case - correct me if I'm wrong?
>
>
> Generally, I agree, but the resulting code here is quite a bit clearer?
> Perhaps if not for the sake of cleaning up warnings, there are just fewer
> codepaths to maintain here?
>

Fair enough - I'll leave it to the code owners/people working in this area
to decide there. Thanks :)


>
>
> http://reviews.llvm.org/D18087
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160311/5b318a7e/attachment.html>