[PATCH] D18087: [mips] Eliminate instances of "potentially uninitialised local variable" warnings, NFC

Alexander Riccio via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 13:20:48 PST 2016


ariccio added a comment.

In http://reviews.llvm.org/D18087#373341, @dblaikie wrote:

> I'm still not sure cleaning up these warnings is worthwhile. If we aren't
>  going to get warning clean & keep the warning on/maintained (in which case
>  I'd really advocate for us to use Clang's version and/or implement the
>  necessary variant in Clang) what's the merit in rephrasing the cases that
>  aren't buggy (this appears to be such a case - correct me if I'm wrong?


Generally, I agree, but the resulting code here is quite a bit clearer? Perhaps if not for the sake of cleaning up warnings, there are just fewer codepaths to maintain here?


http://reviews.llvm.org/D18087





More information about the llvm-commits mailing list