[PATCH] D17830: [MBP] Avoid placing random blocks between loop preheader and header

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 15:08:05 PST 2016


reames added inline comments.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:210
@@ -209,3 +209,3 @@
   /// in-loop predecessors of this chain.
   unsigned LoopPredecessors;
 };
----------------
As a side note, the name of this variable is highly misleading.  When scheduling function chains, this is used to track unscheduled predecessors outside of any loop.  Once this change is in, I'd like to rename this to something more meaningful.  Any suggestions?


http://reviews.llvm.org/D17830





More information about the llvm-commits mailing list