[PATCH] D17830: [MBP] Avoid placing random blocks between loop preheader and header

[Chandler Carruth via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Gah, excellent bug fix. That makes perfect sense to me, and thanks!


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:210
@@ -209,3 +209,3 @@
   /// in-loop predecessors of this chain.
   unsigned LoopPredecessors;
 };
----------------
reames wrote:
> As a side note, the name of this variable is highly misleading.  When scheduling function chains, this is used to track unscheduled predecessors outside of any loop.  Once this change is in, I'd like to rename this to something more meaningful.  Any suggestions?
No real idea. =/ I agree, it was bad when it started and it has gotten worse.


http://reviews.llvm.org/D17830