[PATCH] D14972: [safestack] Protect byval function arguments.

[Peter Collingbourne via llvm-commits]

Lgtm once sdag change lands.

On November 25, 2015 5:34:38 PM PST, Evgeniy Stepanov <eugenis at google.com> wrote:
>eugenis added inline comments.
>
>================
>Comment at: lib/Transforms/Instrumentation/SafeStack.cpp:492
>@@ -462,1 +491,3 @@
>   int64_t StaticOffset = 0; // Current stack top.
>+  IRB.SetInsertPoint(cast<Instruction>(BasePointer->getNextNode()));
>+
>----------------
>pcc wrote:
>> Is it necessary to cast the result of `getNextNode` (here and
>elsewhere)? Looks like it already returns an instruction (see e.g. line
>516).
>Right, it works without a cast. Fixed in multiple places.
>
>
>Repository:
>  rL LLVM
>
>http://reviews.llvm.org/D14972

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151125/4b20cd4c/attachment.html>