<html><head></head><body>Lgtm once sdag change lands.<br><br><div class="gmail_quote">On November 25, 2015 5:34:38 PM PST, Evgeniy Stepanov <eugenis@google.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">eugenis added inline comments.<br /><br />================<br />Comment at: lib/Transforms/Instrumentation/SafeStack.cpp:492<br />@@ -462,1 +491,3 @@<br /> int64_t StaticOffset = 0; // Current stack top.<br />+ IRB.SetInsertPoint(cast<Instruction>(BasePointer->getNextNode()));<br />+<br />----------------<br />pcc wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Is it necessary to cast the result of `getNextNode` (here and elsewhere)? Looks like it already returns an instruction (see e.g. line 516).<br /></blockquote>Right, it works without a cast. Fixed in multiple places.<br /><br /><br />Repository:<br /> rL LLVM<br /><br /><a href="http://reviews.llvm.org/D14972">http://reviews.llvm.org/D14972</a><br /><br /><br /><br /><br /></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>