[PATCH] D14972: [safestack] Protect byval function arguments.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/Transforms/Instrumentation/SafeStack.cpp:492
@@ -462,1 +491,3 @@
   int64_t StaticOffset = 0; // Current stack top.
+  IRB.SetInsertPoint(cast<Instruction>(BasePointer->getNextNode()));
+
----------------
pcc wrote:
> Is it necessary to cast the result of `getNextNode` (here and elsewhere)? Looks like it already returns an instruction (see e.g. line 516).
Right, it works without a cast. Fixed in multiple places.


Repository:
  rL LLVM

http://reviews.llvm.org/D14972