[PATCH] D14129: ELF2: Make .gnu.hash default instead of .hash.

[Igor Kudrin via llvm-commits]

ikudrin added a subscriber: ikudrin.
ikudrin added a comment.

The default settings for hash section should be target-specific. At least MIPS targets don't support GNU-style hash sections at all.


================
Comment at: test/elf2/shared.s:284
@@ -283,3 +283,1 @@
 
-// CHECK:      HashTable {
-// CHECK-NEXT:   Num Buckets: 4
----------------
ruiu wrote:
> grimar wrote:
> > Was the next part of test removed intentionaly ?
> > 
> > // CHECK:      HashTable {
> > // CHECK-NEXT:   Num Buckets: 4
> > // CHECK-NEXT:   Num Chains: 4
> > // CHECK-NEXT:   Buckets: [3, 0, 2, 0]
> > // CHECK-NEXT:   Chains: [0, 0, 0, 1]
> > // CHECK-NEXT: }
> This is intentional.
It looks like we now have no tests which check HashTable section. I'd suggest to add -hash-style=sysv command line switch at least for this test case.


http://reviews.llvm.org/D14129