[PATCH] D14129: ELF2: Make .gnu.hash default instead of .hash.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: test/elf2/discard-none.s:49
@@ -49,2 +48,3 @@
+// CHECK-NEXT:     Value: 0x154
 // CHECK-NEXT:     Size: 0
 // CHECK-NEXT:     Binding: Local
----------------
grimar wrote:
> ruiu wrote:
> > grimar wrote:
> > > Do we really need to mantain adresses in such cases ? They changes often, may be we should just skip checking here like:
> > > // CHECK-NEXT:     Value: 0x
> > > ?
> > I feel like this serves the purpose as a safeguard. Not sure how effective that is, but I don't think removing that is the right thing to do in this patch.
> The problem I see here that single patch changes too many files that are not relative to core idea of patch at all. Also dont see whats the safeguard can be here. Does it save from addresses not being generated ?
> But you`re right that it is not the problem of this patch generally.
I mean not this patch changes, but patches usually do.


http://reviews.llvm.org/D14129