[PATCH] D14129: ELF2: Make .gnu.hash default instead of .hash.

[Rui Ueyama via llvm-commits]

On Tue, Oct 27, 2015 at 11:20 PM, Igor Kudrin <ikudrin.dev at gmail.com> wrote:

> ikudrin added a subscriber: ikudrin.
> ikudrin added a comment.
>
> The default settings for hash section should be target-specific. At least
> MIPS targets don't support GNU-style hash sections at all.
>

That's why I didn't submit this patch right away. Do MIPS compilers pass
--hash-style=sysv to the linker? Also, why don't they support the GNU-style
hash table?



>
> ================
> Comment at: test/elf2/shared.s:284
> @@ -283,3 +283,1 @@
>
> -// CHECK:      HashTable {
> -// CHECK-NEXT:   Num Buckets: 4
> ----------------
> ruiu wrote:
> > grimar wrote:
> > > Was the next part of test removed intentionaly ?
> > >
> > > // CHECK:      HashTable {
> > > // CHECK-NEXT:   Num Buckets: 4
> > > // CHECK-NEXT:   Num Chains: 4
> > > // CHECK-NEXT:   Buckets: [3, 0, 2, 0]
> > > // CHECK-NEXT:   Chains: [0, 0, 0, 1]
> > > // CHECK-NEXT: }
> > This is intentional.
> It looks like we now have no tests which check HashTable section. I'd
> suggest to add -hash-style=sysv command line switch at least for this test
> case.
>
>
> http://reviews.llvm.org/D14129
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151028/155f7e95/attachment.html>