[PATCH] TableGen CGIOperandList should use NumOutOperands instead of NumDefs

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 16:18:14 PDT 2015


> On Oct 27, 2015, at 7:08 PM, Hal Finkel via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Hi Aaron,
> 
> +  bool addToDefs = false;
> 
> This should be named AddToDefs (local variables in LLVM start with a capital letter).
> 
> Can you provide a small TableGen snippet showing the kinds of definitions this affects?
> 
> Thanks,
> Hal
> 

These can be found in HSAILInstrFormats.td (in http://reviews.llvm.org/D9751 <http://reviews.llvm.org/D9751>) in multiclass LD_Types for the multiple result load instructions
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151027/2b4f8fae/attachment.html>


More information about the llvm-commits mailing list