[PATCH] TableGen CGIOperandList should use NumOutOperands instead of NumDefs

[Hal Finkel via llvm-commits]

Hi Aaron, 

+ bool addToDefs = false; 

This should be named AddToDefs (local variables in LLVM start with a capital letter). 

Can you provide a small TableGen snippet showing the kinds of definitions this affects? 

Thanks, 
Hal 

----- Original Message -----

> From: "Aaron Shi (en ye) via llvm-commits"
> <llvm-commits at lists.llvm.org>
> To: llvm-commits at lists.llvm.org
> Sent: Tuesday, October 13, 2015 3:24:52 PM
> Subject: [PATCH] TableGen CGIOperandList should use NumOutOperands
> instead of NumDefs

> Hello,

> I’d like to commit a one-off patch to llvm. I have attached the patch
> file with svn diff.

> Changes made:
> LLVM TableGen CodeGen CGIOperandList object uses NumDefs when it
> should be Num of Out Operands
> 1. Added unsigned NumOutOperands to separate from NumDefs, which
> allows instructions to have the proper number of defs if using
> vector operands with multiple defs in one out
> 2. NumOutOperands counts number of outs in the OutOperandList DAG
> 3. NumDefs will count all the defs including the suboperand defs
> which are inside vector operands
> 4. Changes llvm r232798 to utilise NumOutOperands instead of NumDefs

> This also allows MachineCSE Pass to receive proper number of Defs if
> vector ‘out’s with multiple ‘def’s are used.

> Thanks,
> Aaron (En Ye) Shi Description: Description: Description: green
> PEY, SW Engineering | Stream OpenCL
> 1 Commerce Valley Dr E, Markham, ON L3T 3X6
> O +(1) 289-695-0685 M +(1) 647-709-3020
> Description: Description: Description: image004facebook | amd.com

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 

Hal Finkel 
Assistant Computational Scientist 
Leadership Computing Facility 
Argonne National Laboratory 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151027/9250f2da/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.png
Type: image/png
Size: 360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151027/9250f2da/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 3857 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151027/9250f2da/attachment-0001.png>