<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 27, 2015, at 7:08 PM, Hal Finkel via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; font-family: arial, helvetica, sans-serif; font-size: 10pt;" class="">Hi Aaron,<br class=""><br class="">+ bool addToDefs = false;<br class=""><br class="">This should be named AddToDefs (local variables in LLVM start with a capital letter).<br class=""><br class="">Can you provide a small TableGen snippet showing the kinds of definitions this affects?<br class=""><br class="">Thanks,<br class="">Hal<br class=""></div></div></blockquote><blockquote type="cite" class=""><br class=""></blockquote><br class=""></div><div>These can be found in HSAILInstrFormats.td (in <a href="http://reviews.llvm.org/D9751" class="">http://reviews.llvm.org/D9751</a>) in multiclass LD_Types for the multiple result load instructions</div></body></html>