<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: arial,helvetica,sans-serif; font-size: 10pt; color: #000000'>Hi Aaron,<br><br>+ bool addToDefs = false;<br><br>This should be named AddToDefs (local variables in LLVM start with a capital letter).<br><br>Can you provide a small TableGen snippet showing the kinds of definitions this affects?<br><br>Thanks,<br>Hal<br><br><hr id="zwchr"><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Aaron Shi (en ye) via llvm-commits" <llvm-commits@lists.llvm.org><br><b>To: </b>llvm-commits@lists.llvm.org<br><b>Sent: </b>Tuesday, October 13, 2015 3:24:52 PM<br><b>Subject: </b>[PATCH] TableGen CGIOperandList should use NumOutOperands instead of NumDefs<br><br>
<style><!--
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
<div class="WordSection1">
<p class="MsoNormal">Hello,</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">I’d like to commit a one-off patch to llvm. I have attached the patch file with svn diff.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Changes made:</p>
<p class="MsoNormal">LLVM TableGen CodeGen CGIOperandList object uses NumDefs when it should be Num of Out Operands</p>
<p class="MsoNormal">1. Added unsigned NumOutOperands to separate from NumDefs, which allows instructions to have the proper number of defs if using vector operands with multiple defs in one out</p>
<p class="MsoNormal">2. NumOutOperands counts number of outs in the OutOperandList DAG</p>
<p class="MsoNormal">3. NumDefs will count all the defs including the suboperand defs which are inside vector operands</p>
<p class="MsoNormal">4. Changes llvm r232798 to utilise NumOutOperands instead of NumDefs</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">This also allows MachineCSE Pass to receive proper number of Defs if vector ‘out’s with multiple ‘def’s are used.
</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Thanks,</p>
<p class="MsoNormal"><b><span style="color: black; text-transform: uppercase;">Aaron (En Ye) Shi</span></b><span style="font-size: 10pt; color: black;">
<img id="Picture_x0020_30" src="cid:image004.png@01D105D3.AFB61880" alt="Description: Description: Description: green" height="10" width="10"><br>
PEY, SW Engineering | Stream OpenCL<br>
1 Commerce Valley Dr E, Markham, ON L3T 3X6<br>
<b>O</b> +(1) 289-695-0685 <b>M</b> +(1) 647-709-3020<br>
<img id="Picture_x0020_31" src="cid:image003.png@01D105D3.30C54CD0" alt="Description: Description: Description: image004" height="22" width="69">
</span><a href="https://www.facebook.com/AMD" target="_blank"><span style="font-size: 10pt; color: black;">facebook</span></a><span style="font-size: 10pt; color: black;"> |
</span><a href="http://www.amd.com/" target="_blank"><span style="font-size: 10pt; color: black;">amd.com</span></a><span style="font-size: 10pt; color: black;"></span></p>
<p class="MsoNormal"> </p>
</div>
<br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br></blockquote><br><br><br>-- <br><div><span name="x"></span>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<span name="x"></span><br></div></div></body></html>