[PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 21:44:06 PDT 2015

Hi Artyom,

I'd prefer to hear from Peter if he agrees with your course of action
first, as he raised concerns.

On Mon, 21 Sep 2015 at 13:54, A. Skrobov via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> tyomitch added a comment.
> Responding to Peter's comment above: the option 2 (adding FeatureDSPARM
> which can be enabled or disabled indepentently from FeatureDSPThumb2) seems
> a bit of overengineering for no gain: in the existing ARM architectures,
> the DSP extension is either available from all supported instruction sets,
> or from none of them.
> It would be ideal to call this "FeatureDSP", and to avoid associating this
> extension with either of the instruction sets; but unfortunately the
> "+t2dsp" syntax has already been exposed as part of LLVM/Clang user
> interface, and there may be external scripts specifying this feature name.
> Therefore, in my commit 248152 (later reverted by James) I went for option
> 1, that is, to update the description for FeatureDSPThumb2 to match its new
> purpose.
> Renato et al.: is it OK to recommit this patch, including its clang-side
> counterpart http://reviews.llvm.org/D12938 which James also reverted?
> Repository:
>   rL LLVM
> http://reviews.llvm.org/D12937
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150922/79292091/attachment.html>

More information about the llvm-commits mailing list