[PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

A. Skrobov via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 13:54:10 PDT 2015

tyomitch added a comment.

Responding to Peter's comment above: the option 2 (adding FeatureDSPARM which can be enabled or disabled indepentently from FeatureDSPThumb2) seems a bit of overengineering for no gain: in the existing ARM architectures, the DSP extension is either available from all supported instruction sets, or from none of them.

It would be ideal to call this "FeatureDSP", and to avoid associating this extension with either of the instruction sets; but unfortunately the "+t2dsp" syntax has already been exposed as part of LLVM/Clang user interface, and there may be external scripts specifying this feature name.

Therefore, in my commit 248152 (later reverted by James) I went for option 1, that is, to update the description for FeatureDSPThumb2 to match its new purpose.

Renato et al.: is it OK to recommit this patch, including its clang-side counterpart http://reviews.llvm.org/D12938 which James also reverted?



More information about the llvm-commits mailing list