[PATCH] D12844: Support align attribute for return values

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 05:23:02 PDT 2015


apilipenko added inline comments.

================
Comment at: test/Analysis/ValueTracking/memory-dereferenceable.ll:120
@@ +119,3 @@
+    %deref_return = call dereferenceable(32) i32* @foo()
+    %deref_and_aligned_return = call dereferenceable(32) align 16 i32* @foo()
+    %load23 = load i32, i32* %no_deref_return
----------------
reames wrote:
> The syntax here feels really weird for me.  "align 16" vs "align(16)" feels very inconsistent with "dereferenceable(32)".  Not saying we need to fix that right now, just noting it.  
BTW, do we care about backward compatibility of textual representation?


http://reviews.llvm.org/D12844





More information about the llvm-commits mailing list