[PATCH] D12844: Support align attribute for return values

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: test/Analysis/ValueTracking/memory-dereferenceable.ll:120
@@ +119,3 @@
+    %deref_return = call dereferenceable(32) i32* @foo()
+    %deref_and_aligned_return = call dereferenceable(32) align 16 i32* @foo()
+    %load23 = load i32, i32* %no_deref_return
----------------
apilipenko wrote:
> reames wrote:
> > The syntax here feels really weird for me.  "align 16" vs "align(16)" feels very inconsistent with "dereferenceable(32)".  Not saying we need to fix that right now, just noting it.  
> BTW, do we care about backward compatibility of textual representation?
Not really.  I'd say don't break it needlessly, but the IR is a living format with no compatibility guarantees.  Provided all the in-tree tests have been updated, that's it.  (If you are going to change format, please do so in a separate change.)


http://reviews.llvm.org/D12844