[PATCH] D12844: Support align attribute for return values

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 05:08:36 PDT 2015


apilipenko added inline comments.

================
Comment at: lib/AsmParser/LLParser.cpp:1382
@@ -1381,1 +1381,3 @@
     }
+    case lltok::kw_align: {
+      unsigned Alignment;
----------------
reames wrote:
> The fact your changing the IR parser and not the IR writer, bitcode parser, or bitcode writer seems mildly suspect.  Have you tested the ability to round trip through both IR and Bitcode?
Yes, I have. Other parts work fine.


http://reviews.llvm.org/D12844





More information about the llvm-commits mailing list