[PATCH] D12248: Put profile variables of COMDAT functions to it's own COMDAT group

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 11:47:00 PDT 2015


On Sep 11, 2015 1:10 PM, "Rong Xu" <xur at google.com> wrote:

> On Fri, Sep 11, 2015 at 7:17 AM, Diego Novillo <dnovillo at google.com>
> wrote:
>
>> dnovillo added a comment.
>>
>> With David's suggestions and a test case, this LGTM.
>>
>
> Hi Diego,
>
> Thanks for the review. One question: Is the test case a regression test to
> test the new comdat group is generated, or a test case that reproduces
> current behavior of seg-fault?
>

The test would check the new comdat section for the profile variables.


Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150911/80c0d61a/attachment.html>


More information about the llvm-commits mailing list