[PATCH] D12248: Put profile variables of COMDAT functions to it's own COMDAT group

[Xinliang David Li via llvm-commits]

Test the new behavior.

David

On Fri, Sep 11, 2015 at 10:10 AM, Rong Xu <xur at google.com> wrote:

> On Fri, Sep 11, 2015 at 7:17 AM, Diego Novillo <dnovillo at google.com>
> wrote:
>
>> dnovillo added a comment.
>>
>> With David's suggestions and a test case, this LGTM.
>>
>
> Hi Diego,
>
> Thanks for the review. One question: Is the test case a regression test to
> test the new comdat group is generated, or a test case that reproduces
> current behavior of seg-fault?
>
>
> -Rong
>
>
>>
>>
>> ================
>> Comment at: InstrProfiling.cpp:199
>> @@ -198,4 +198,3 @@
>>
>> -  // Move the name variable to the right section. Make sure it is placed
>> in the
>> -  // same comdat as its associated function. Otherwise, we may get
>> multiple
>> -  // counters for the same function in certain cases.
>> +  // Move the name variable to the right section. Make them in a COMDAT
>> group
>> +  // if the associated function is a COMDAT. This will make sure that
>> ----------------
>> s/Make/Place/
>>
>>
>> http://reviews.llvm.org/D12248
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150911/b1a9c40f/attachment.html>