[PATCH] D10674: Value profiling - patchset 3

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 12:04:18 PDT 2015


On Tue, Sep 8, 2015 at 11:47 AM, Betul Buyukkurt via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> > davidxl added inline comments.
> >
> > ================
> > Comment at: lib/ProfileData/InstrProfReader.cpp:344
> > @@ +343,3 @@
> > +          auto Result = HashKeyMap.find(Value);
> > +          assert(Result != HashKeyMap.end() &&
> > +                 "Hash does not match any known keys\n");
> > ----------------
> > I actually meant to add an assert that the only supported value kind is
> > indirect_call_target for now.
>
> I think this can be handled this in future patches. What do you think?
>

I have not problem with it.

David


>
> Justin, could you please comment on the patch as well?
>
> -Betul
>
> >
> >
> >
> > http://reviews.llvm.org/D10674
> >
> >
> >
> >
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150908/6d911c3a/attachment.html>


More information about the llvm-commits mailing list