<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 8, 2015 at 11:47 AM, Betul Buyukkurt via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> davidxl added inline comments.<br>
><br>
> ================<br>
> Comment at: lib/ProfileData/InstrProfReader.cpp:344<br>
> @@ +343,3 @@<br>
> +          auto Result = HashKeyMap.find(Value);<br>
> +          assert(Result != HashKeyMap.end() &&<br>
> +                 "Hash does not match any known keys\n");<br>
> ----------------<br>
> I actually meant to add an assert that the only supported value kind is<br>
> indirect_call_target for now.<br>
<br>
</span>I think this can be handled this in future patches. What do you think?<br></blockquote><div><br></div><div>I have not problem with it.</div><div><br></div><div>David</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Justin, could you please comment on the patch as well?<br>
<span class="HOEnZb"><font color="#888888"><br>
-Betul<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
><br>
><br>
> <a href="http://reviews.llvm.org/D10674" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10674</a><br>
><br>
><br>
><br>
><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>