[PATCH] D10674: Value profiling - patchset 3

[Betul Buyukkurt via llvm-commits]

betulb added a comment.

> davidxl added inline comments.

> 

> ================

>  Comment at: lib/ProfileData/InstrProfReader.cpp:344

>  @@ +343,3 @@

>  +          auto Result = HashKeyMap.find(Value);

>  +          assert(Result != HashKeyMap.end() &&

>  +                 "Hash does not match any known keys\n");

> 

>  ----------------

> 

> I actually meant to add an assert that the only supported value kind is

>  indirect_call_target for now.


I think this can be handled this in future patches. What do you think?

Justin, could you please comment on the patch as well?

-Betul

> http://reviews.llvm.org/D10674



http://reviews.llvm.org/D10674