[llvm] r245119 - Fix a crash where a utility function wasn't aware of fcmp vectors and created a value with the wrong type. Fixes PR24458!

[David Majnemer via llvm-commits]

On Mon, Aug 17, 2015 at 10:19 PM, Nick Lewycky via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Hans Wennborg wrote:
>
>> On Fri, Aug 14, 2015 at 3:46 PM, Nick Lewycky via llvm-commits
>> <llvm-commits at lists.llvm.org>  wrote:
>>
>>> Author: nicholas
>>> Date: Fri Aug 14 17:46:49 2015
>>> New Revision: 245119
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=245119&view=rev
>>> Log:
>>> Fix a crash where a utility function wasn't aware of fcmp vectors and
>>> created a value with the wrong type. Fixes PR24458!
>>>
>>> Modified:
>>>      llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
>>>      llvm/trunk/test/Transforms/InstCombine/vector-casts.ll
>>>
>>
>> Should we merge this to 3.7?
>>
>
> Arguable:
>
> * It does meet the standard for a simple, obvious correct fix.
> * It does not meet the standard for being a regression against the
> previous release.
>
> Weighing the two issues, I'd say you can take this patch unless you're
> being extremely risk-averse (ie., already many release candidates deep into
> the release process). David?


I think it's fine to merge this into 3.7


>
>
> Nick
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150818/bc994849/attachment.html>