[llvm] r245119 - Fix a crash where a utility function wasn't aware of fcmp vectors and created a value with the wrong type. Fixes PR24458!

Nick Lewycky via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 22:19:36 PDT 2015


Hans Wennborg wrote:
> On Fri, Aug 14, 2015 at 3:46 PM, Nick Lewycky via llvm-commits
> <llvm-commits at lists.llvm.org>  wrote:
>> Author: nicholas
>> Date: Fri Aug 14 17:46:49 2015
>> New Revision: 245119
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=245119&view=rev
>> Log:
>> Fix a crash where a utility function wasn't aware of fcmp vectors and created a value with the wrong type. Fixes PR24458!
>>
>> Modified:
>>      llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
>>      llvm/trunk/test/Transforms/InstCombine/vector-casts.ll
>
> Should we merge this to 3.7?

Arguable:

* It does meet the standard for a simple, obvious correct fix.
* It does not meet the standard for being a regression against the 
previous release.

Weighing the two issues, I'd say you can take this patch unless you're 
being extremely risk-averse (ie., already many release candidates deep 
into the release process). David?

Nick


More information about the llvm-commits mailing list