<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 17, 2015 at 10:19 PM, Nick Lewycky via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Hans Wennborg wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Fri, Aug 14, 2015 at 3:46 PM, Nick Lewycky via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>  wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: nicholas<br>
Date: Fri Aug 14 17:46:49 2015<br>
New Revision: 245119<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245119&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245119&view=rev</a><br>
Log:<br>
Fix a crash where a utility function wasn't aware of fcmp vectors and created a value with the wrong type. Fixes PR24458!<br>
<br>
Modified:<br>
     llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp<br>
     llvm/trunk/test/Transforms/InstCombine/vector-casts.ll<br>
</blockquote>
<br>
Should we merge this to 3.7?<br>
</blockquote>
<br></span>
Arguable:<br>
<br>
* It does meet the standard for a simple, obvious correct fix.<br>
* It does not meet the standard for being a regression against the previous release.<br>
<br>
Weighing the two issues, I'd say you can take this patch unless you're being extremely risk-averse (ie., already many release candidates deep into the release process). David?</blockquote><div><br></div><div>I think it's fine to merge this into 3.7</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><br>
<br>
Nick</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>