[PATCH] Change .thumb_set to have the same error checks as .set

[Pete Cooper]

> On Jun 22, 2015, at 9:49 AM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> 
>> On Jun 22, 2015, at 9:38 AM, Rafael Espíndola <rafael.espindola at gmail.com <mailto:rafael.espindola at gmail.com>> wrote:
>> 
>> I am probably missing something,  but why can't parseAssignmentExpression be a method of the Asm Parser? Can't the arm specific one call the generic one?
>> 
> Ah, you’re right.  I just hadn’t dug deep enough in to the class hierarchy.  Yeah I think we can get the AsmParser using getParser() in ARMArmParser.  Will prepare a much simpler patch to do just that.
Oh wait, i was wrong.

So AsmParser.cpp doesn’t have a header file.  Its a subclass of MCAsmParser.  ARMAsmParser itself is a parser extension, but (obviously given there’s no header), there’s no way to get from a parser extension to AsmParser.  

Everything is connected once you’re down at the MC level, but I didn’t want to expose this functionality in MCAsmParser as it doesn’t fit in with the other methods there.

Cheers,
Pete
> 
> Pete
>> 
>> On Jun 22, 2015 12:32 PM, "Pete Cooper" <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
>> Here’s an updated patch.  Just deleted the isSymbolUsedInExpression from the header, and moved its comment to the (now static) version in AsmParser.cpp.
>> 
>> Cheers,
>> Pete
>> 
>> 
>> 
>> 
>> 
>> > On Jun 21, 2015, at 8:47 PM, Rafael Espíndola <rafael.espindola at gmail.com <mailto:rafael.espindola at gmail.com>> wrote:
>> >
>> >> I like having it in the MCAsmParserUtils namespace, but can just make it a
>> >> local static as you said.
>> >
>> > Yes, lets keep it a static for now.
>> >
>> > Thanks,
>> > Rafael
>> 
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/c8f19fe2/attachment.html>