[PATCH] Change .thumb_set to have the same error checks as .set

[Pete Cooper]

> On Jun 22, 2015, at 9:38 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> I am probably missing something,  but why can't parseAssignmentExpression be a method of the Asm Parser? Can't the arm specific one call the generic one?
> 
Ah, you’re right.  I just hadn’t dug deep enough in to the class hierarchy.  Yeah I think we can get the AsmParser using getParser() in ARMArmParser.  Will prepare a much simpler patch to do just that.

Pete
> On Jun 22, 2015 12:32 PM, "Pete Cooper" <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Here’s an updated patch.  Just deleted the isSymbolUsedInExpression from the header, and moved its comment to the (now static) version in AsmParser.cpp.
> 
> Cheers,
> Pete
> 
> 
> 
> 
> 
> > On Jun 21, 2015, at 8:47 PM, Rafael Espíndola <rafael.espindola at gmail.com <mailto:rafael.espindola at gmail.com>> wrote:
> >
> >> I like having it in the MCAsmParserUtils namespace, but can just make it a
> >> local static as you said.
> >
> > Yes, lets keep it a static for now.
> >
> > Thanks,
> > Rafael
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/2a3259f7/attachment.html>