<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 22, 2015, at 9:49 AM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 22, 2015, at 9:38 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class="">I am probably missing something, but why can't <font class="">parseAssignmentExpression be a method of the Asm Parser? Can't the arm specific one call the generic one?</font><br class=""></p></div></blockquote>Ah, you’re right. I just hadn’t dug deep enough in to the class hierarchy. Yeah I think we can get the AsmParser using getParser() in ARMArmParser. Will prepare a much simpler patch to do just that.</div></div></div></blockquote>Oh wait, i was wrong.</div><div><br class=""></div><div>So AsmParser.cpp doesn’t have a header file. Its a subclass of MCAsmParser. ARMAsmParser itself is a parser extension, but (obviously given there’s no header), there’s no way to get from a parser extension to AsmParser. </div><div><br class=""></div><div>Everything is connected once you’re down at the MC level, but I didn’t want to expose this functionality in MCAsmParser as it doesn’t fit in with the other methods there.</div><div><br class=""></div><div>Cheers,</div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Pete<br class=""><blockquote type="cite" class=""><div class=""><div class="">
<br class="webkit-block-placeholder"></div>
<div class="gmail_quote">On Jun 22, 2015 12:32 PM, "Pete Cooper" <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:<br type="attribution" class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here’s an updated patch. Just deleted the isSymbolUsedInExpression from the header, and moved its comment to the (now static) version in AsmParser.cpp.<br class="">
<br class="">
Cheers,<br class="">
Pete<br class="">
<br class="">
<br class=""><br class="">
<br class="">
<br class="">
> On Jun 21, 2015, at 8:47 PM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" class="">rafael.espindola@gmail.com</a>> wrote:<br class="">
><br class="">
>> I like having it in the MCAsmParserUtils namespace, but can just make it a<br class="">
>> local static as you said.<br class="">
><br class="">
> Yes, lets keep it a static for now.<br class="">
><br class="">
> Thanks,<br class="">
> Rafael<br class="">
<br class="">
<br class=""></blockquote></div>
</div></blockquote></div><br class=""></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>