[PATCH] Change .thumb_set to have the same error checks as .set
Rafael Espíndola
rafael.espindola at gmail.com
Mon Jun 22 09:38:42 PDT 2015
I am probably missing something, but why can't parseAssignmentExpression
be a method of the Asm Parser? Can't the arm specific one call the generic
one?
On Jun 22, 2015 12:32 PM, "Pete Cooper" <peter_cooper at apple.com> wrote:
> Here’s an updated patch. Just deleted the isSymbolUsedInExpression from
> the header, and moved its comment to the (now static) version in
> AsmParser.cpp.
>
> Cheers,
> Pete
>
>
>
>
>
> > On Jun 21, 2015, at 8:47 PM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
> >
> >> I like having it in the MCAsmParserUtils namespace, but can just make
> it a
> >> local static as you said.
> >
> > Yes, lets keep it a static for now.
> >
> > Thanks,
> > Rafael
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150622/9c63620e/attachment.html>
More information about the llvm-commits
mailing list