[PATCH] Add intrinsics and SDNodes for umin, umax, smin and smax.

[James Molloy]

Hi Philip,

Thanks, I'll send an email to llvmdev shortly.

Cheers,

James

On Mon, 27 Apr 2015 at 17:39 Philip Reames <listmail at philipreames.com>
wrote:

> Everything seems reasonable to me, but I'm not familiar enough with all
> the parts touched to sign off.
>
> Also, you should make sure this gets highlighted on llvmdev.  Summarize
> the current proposal, link to the review thread discussion, and give folks
> a chance to see the changes proposed.  It's possible there's something
> we've missed when thinking about the trade offs.
>
>
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5461
> @@ +5460,3 @@
> +    setValue(&I, DAG.getNode(ISD::SMIN, sdl,
> +                             getValue(I.getArgOperand(0)).getValueType(),
> +                             getValue(I.getArgOperand(0)),
> ----------------
> Mild preference to pull out an LHS variable since you're using it twice.
> Same for each case below.
>
> http://reviews.llvm.org/D9293
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150427/15cda9e5/attachment.html>