<div dir="ltr">Hi Philip,<br><br>Thanks, I'll send an email to llvmdev shortly.<div><br></div><div>Cheers,</div><div><br></div><div>James</div></div><br><div class="gmail_quote">On Mon, 27 Apr 2015 at 17:39 Philip Reames <<a href="mailto:listmail@philipreames.com">listmail@philipreames.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Everything seems reasonable to me, but I'm not familiar enough with all the parts touched to sign off.<br>
<br>
Also, you should make sure this gets highlighted on llvmdev.  Summarize the current proposal, link to the review thread discussion, and give folks a chance to see the changes proposed.  It's possible there's something we've missed when thinking about the trade offs.<br>
<br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5461<br>
@@ +5460,3 @@<br>
+    setValue(&I, DAG.getNode(ISD::SMIN, sdl,<br>
+                             getValue(I.getArgOperand(0)).getValueType(),<br>
+                             getValue(I.getArgOperand(0)),<br>
----------------<br>
Mild preference to pull out an LHS variable since you're using it twice.  Same for each case below.<br>
<br>
<a href="http://reviews.llvm.org/D9293" target="_blank">http://reviews.llvm.org/D9293</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>