[PATCH] Add intrinsics and SDNodes for umin, umax, smin and smax.

[Philip Reames]

Everything seems reasonable to me, but I'm not familiar enough with all the parts touched to sign off.

Also, you should make sure this gets highlighted on llvmdev.  Summarize the current proposal, link to the review thread discussion, and give folks a chance to see the changes proposed.  It's possible there's something we've missed when thinking about the trade offs.


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5461
@@ +5460,3 @@
+    setValue(&I, DAG.getNode(ISD::SMIN, sdl,
+                             getValue(I.getArgOperand(0)).getValueType(),
+                             getValue(I.getArgOperand(0)),
----------------
Mild preference to pull out an LHS variable since you're using it twice.  Same for each case below.

http://reviews.llvm.org/D9293

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/