[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order

Timur Iskhodzhanov timurrrr at google.com
Fri Mar 27 11:05:19 PDT 2015


Rationale: we have a possible UAF in the RTL.
We either leak [see r233257] or UAF or manage the strings somehow.
A possible alternative is to replace `char **module_name` kind of returning a string to "pass us a fixed-size buffer" and `char *module_name`.


================
Comment at: sanitizer_symbolizer.cc:78
@@ -77,1 +77,3 @@
 
+Symbolizer::ModuleNameOwner::~ModuleNameOwner() {
+  for (uptr i = 0; i < storage_.size(); ++i)
----------------
kcc wrote:
> Why do you need a DTOR? 
> Are you ever going to call it except for when the process is dying? 
Correct.  Should I remove it?

http://reviews.llvm.org/D8666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list