[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order
Kostya Serebryany
kcc at google.com
Fri Mar 27 11:01:42 PDT 2015
What is the rationale? I see added complexity but don't see the benefit
================
Comment at: sanitizer_symbolizer.cc:78
@@ -77,1 +77,3 @@
+Symbolizer::ModuleNameOwner::~ModuleNameOwner() {
+ for (uptr i = 0; i < storage_.size(); ++i)
----------------
Why do you need a DTOR?
Are you ever going to call it except for when the process is dying?
http://reviews.llvm.org/D8666
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list