[PATCH] [Sanitizer RT] Put the module name string ownership in Symbolizer in order

Kostya Serebryany kcc at google.com
Fri Mar 27 11:08:24 PDT 2015


In http://reviews.llvm.org/D8666#147984, @timurrrr wrote:

> Rationale: we have a possible UAF in the RTL.
>  We either leak [see r233257] or UAF or manage the strings somehow.
>  A possible alternative is to replace `char **module_name` kind of returning a string to "pass us a fixed-size buffer" and `char *module_name`.


"pass us a fixed-size buffer" (i.e. the caller owns the buffer, we copy data there is better here, imho


http://reviews.llvm.org/D8666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list