[PATCH] Verify 'optnone' can run DAG combiner when appropriate

[Eric Christopher]

On Wed, Mar 25, 2015 at 1:28 PM Eric Christopher <echristo at gmail.com> wrote:

> Inline comment.
>
>
> ================
> Comment at: test/CodeGen/X86/dag-optnone.ll:7
> @@ +6,3 @@
> +; that the combine is expected.
> +; Note, this will start failing if somebody decides that this combine
> should
> +; not occur at -O0 (because 'optnone' essentially sets -O0 for the
> function).
> ----------------
> Could you describe the problem that would occur were the dag combiner not
> run? That hasn't been clear either in this test or in your original commit
> reverting.
>
>
Resending because I typoed and it's unclear I think:

"What caused you to notice not running the DAG combiner was a problem?"

-eric


> http://reviews.llvm.org/D8614
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150325/bb31c9d6/attachment.html>