<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Mar 25, 2015 at 1:28 PM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Inline comment.<br>
<br>
<br>
================<br>
Comment at: test/CodeGen/X86/dag-optnone.<u></u>ll:7<br>
@@ +6,3 @@<br>
+; that the combine is expected.<br>
+; Note, this will start failing if somebody decides that this combine should<br>
+; not occur at -O0 (because 'optnone' essentially sets -O0 for the function).<br>
----------------<br>
Could you describe the problem that would occur were the dag combiner not run? That hasn't been clear either in this test or in your original commit reverting.<br>
<br></blockquote><div><br></div><div>Resending because I typoed and it's unclear I think:</div><div><br></div><div>"What caused you to notice not running the DAG combiner was a problem?"</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="http://reviews.llvm.org/D8614" target="_blank">http://reviews.llvm.org/D8614</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>