[PATCH] Verify 'optnone' can run DAG combiner when appropriate

Eric Christopher echristo at gmail.com
Wed Mar 25 13:23:46 PDT 2015


Inline comment.


================
Comment at: test/CodeGen/X86/dag-optnone.ll:7
@@ +6,3 @@
+; that the combine is expected.
+; Note, this will start failing if somebody decides that this combine should
+; not occur at -O0 (because 'optnone' essentially sets -O0 for the function).
----------------
Could you describe the problem that would occur were the dag combiner not run? That hasn't been clear either in this test or in your original commit reverting.

http://reviews.llvm.org/D8614

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list