[PATCH] [Windows] Implementing backtracing of self

[Zachary Turner]

catch-all*

On Thu, Mar 5, 2015 at 10:17 AM Zachary Turner <zturner at google.com> wrote:

> What's the catch-call case then?  Just return from the function and don't
> print anything?
>
> On Thu, Mar 5, 2015 at 10:13 AM David Majnemer <david.majnemer at gmail.com>
> wrote:
>
>> REPOSITORY
>>   rL LLVM
>>
>> ================
>> Comment at: llvm/trunk/lib/Support/Windows/Signals.inc:181-183
>> @@ +180,5 @@
>> +  machineType = IMAGE_FILE_MACHINE_AMD64;
>> +#else
>> +  machineType = IMAGE_FILE_MACHINE_I386;
>> +#endif
>> +
>> ----------------
>> Might be good to make this guarded by `#elif define(_M_IX86)`.
>>
>> ================
>> Comment at: llvm/trunk/lib/Support/Windows/Signals.inc:393
>> @@ +392,3 @@
>> +  StackFrame.AddrFrame.Offset = Context.Rbp;
>> +#else
>> +  StackFrame.AddrPC.Offset = Context.Eip;
>> ----------------
>> This should be `#elif defined(_M_IX86)`
>>
>> http://reviews.llvm.org/D8068
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150305/143f97d5/attachment.html>