<div dir="ltr">catch-all*<br></div><br><div class="gmail_quote">On Thu, Mar 5, 2015 at 10:17 AM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What's the catch-call case then?  Just return from the function and don't print anything?<br></div><br><div class="gmail_quote">On Thu, Mar 5, 2015 at 10:13 AM David Majnemer <<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: llvm/trunk/lib/Support/<u></u>Windows<u></u>/Signals.inc:181-183<br>
@@ +180,5 @@<br>
+  machineType = IMAGE_FILE_MACHINE_AMD64;<br>
+#else<br>
+  machineType = IMAGE_FILE_MACHINE_I386;<br>
+#endif<br>
+<br>
----------------<br>
Might be good to make this guarded by `#elif define(_M_IX86)`.<br>
<br>
================<br>
Comment at: llvm/trunk/lib/Support/<u></u>Windows<u></u>/Signals.inc:393<br>
@@ +392,3 @@<br>
+  StackFrame.AddrFrame.Offset = Context.Rbp;<br>
+#else<br>
+  StackFrame.AddrPC.Offset = Context.Eip;<br>
----------------<br>
This should be `#elif defined(_M_IX86)`<br>
<br>
<a href="http://reviews.llvm.org/D8068" target="_blank">http://reviews.llvm.org/D8068</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settin<u></u>gs/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
</blockquote></div></blockquote></div>