[PATCH] [opaque pointer type] Add textual IR support for explicit type parameter to load instruction

[David Blaikie]

On Thu, Feb 26, 2015 at 1:05 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> Needs tests for the error cases.
>
>
> ================
> Comment at: lib/AsmParser/LLParser.cpp:5169
> @@ +5168,3 @@
> +  Type *Ty = nullptr;
> +  if (ParseType(Ty)) return true;
> +  ParseToken(lltok::comma, "expected comma after getelementptr's type");
> ----------------
> clang-format please.
>

Refactored/reformatted.


>
> ================
> Comment at: lib/AsmParser/LLParser.cpp:5187
> @@ +5186,3 @@
> +
> +  assert(Ty == Inst->getType());
> +
> ----------------
> This is user input, it can fail.
>

Changed to error handling & added test case(s).


>
> http://reviews.llvm.org/D7649
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150226/94dcd951/attachment.html>