[PATCH] [opaque pointer type] Add textual IR support for explicit type parameter to load instruction

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Feb 26 13:05:24 PST 2015


Needs tests for the error cases.


================
Comment at: lib/AsmParser/LLParser.cpp:5169
@@ +5168,3 @@
+  Type *Ty = nullptr;
+  if (ParseType(Ty)) return true;
+  ParseToken(lltok::comma, "expected comma after getelementptr's type");
----------------
clang-format please.

================
Comment at: lib/AsmParser/LLParser.cpp:5187
@@ +5186,3 @@
+
+  assert(Ty == Inst->getType());
+
----------------
This is user input, it can fail.

http://reviews.llvm.org/D7649

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list