<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 26, 2015 at 1:05 PM, Rafael Ávila de Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Needs tests for the error cases.<br>
<br>
<br>
================<br>
Comment at: lib/AsmParser/LLParser.cpp:5169<br>
@@ +5168,3 @@<br>
<span class="">+  Type *Ty = nullptr;<br>
+  if (ParseType(Ty)) return true;<br>
+  ParseToken(lltok::comma, "expected comma after getelementptr's type");<br>
</span>----------------<br>
clang-format please.<br></blockquote><div><br>Refactored/reformatted.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
================<br>
Comment at: lib/AsmParser/LLParser.cpp:5187<br>
@@ +5186,3 @@<br>
<span class="">+<br>
+  assert(Ty == Inst->getType());<br>
+<br>
</span>----------------<br>
This is user input, it can fail.<br></blockquote><div><br>Changed to error handling & added test case(s).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D7649" target="_blank">http://reviews.llvm.org/D7649</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div>